Skip to content

πŸ”€ 토큰 μž¬λ°œκΈ‰ #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 1, 2024
Merged

πŸ”€ 토큰 μž¬λ°œκΈ‰ #8

merged 7 commits into from
Nov 1, 2024

Conversation

ta2ye0n
Copy link
Contributor

@ta2ye0n ta2ye0n commented Nov 1, 2024

πŸ’‘ λ°°κ²½ 및 κ°œμš”

토큰 μž¬λ°œκΈ‰ κΈ°λŠ₯을 κ΅¬ν˜„ν–ˆμŠ΅λ‹ˆλ‹€

Resolves: #7

πŸ“ƒ μž‘μ—…λ‚΄μš©

  • 토큰 μž¬λ°œκΈ‰

πŸ™‹β€β™‚οΈ λ¦¬λ·°λ…ΈνŠΈ

아직 API λͺ…μ„Έμ„œκ°€ λ‹€ μž‘μ„±λ˜μ§€ μ•Šμ•„μ„œ endpoint μž„μ˜λ‘œ μ„€μ •ν•΄λ‘μ—ˆμŠ΅λ‹ˆλ‹€!

βœ… PR 체크리슀트

ν…œν”Œλ¦Ώ 체크리슀트 말고도 μΆ”κ°€μ μœΌλ‘œ ν•„μš”ν•œ μ²΄ν¬λ¦¬μŠ€νŠΈλŠ” μΆ”κ°€ν•΄μ£Όμ„Έμš”!

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. .env, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "ν™˜κ²½κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?
  • 이 μž‘μ—…μœΌλ‘œ 인해 λ°œμƒν•œ λ³€κ²½ 사항이 Resource μ„œλ²„μ—λ„ λ°˜μ˜λ˜μ—ˆλ‚˜μš”?

🎸 기타

@ta2ye0n ta2ye0n added the ✨ Feature μ‹ κ·œ κΈ°λŠ₯ label Nov 1, 2024
@ta2ye0n ta2ye0n self-assigned this Nov 1, 2024
@ta2ye0n ta2ye0n requested a review from Umjiseung as a code owner November 1, 2024 05:07
@ta2ye0n ta2ye0n linked an issue Nov 1, 2024 that may be closed by this pull request
토큰 μž¬λ°œκΈ‰ #7
Closed
KimTaeO
KimTaeO reviewed Nov 1, 2024
View reviewed changes
src/main/java/com/gcms/v3/domain/auth/domain/repository/RefreshTokenRepository.java Outdated

import java.util.Optional;

public interface RefreshTokenRepository extends CrudRepository<RefreshToken, Long> {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RefreshToken의 Id νƒ€μž…μ€ String인데 여기에 Long으둜 λ˜μ–΄μžˆλ„€μš”
String으둜 λ³€κ²½ν•΄ μ£Όμ„Έμš”!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ebbcf15

μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€!

KimTaeO
KimTaeO approved these changes Nov 1, 2024
View reviewed changes
Copy link

@KimTaeO KimTaeO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€~

@ta2ye0n ta2ye0n merged commit c2821f7 into develop Nov 1, 2024
1 check passed
@ta2ye0n ta2ye0n deleted the feature/7-reissue-token branch November 1, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KimTaeO KimTaeO KimTaeO approved these changes

@Umjiseung Umjiseung Awaiting requested review from Umjiseung

Assignees

@ta2ye0n ta2ye0n

Labels
✨ Feature μ‹ κ·œ κΈ°λŠ₯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

토큰 μž¬λ°œκΈ‰
2 participants
@ta2ye0n @KimTaeO